Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Added ui-scroll #620

Closed
wants to merge 2 commits into from
Closed

Added ui-scroll #620

wants to merge 2 commits into from

Conversation

domakas
Copy link

@domakas domakas commented Jan 30, 2015

  • Added ui-scroll
  • Added infinite scroller
  • Added loader

maksidom added 2 commits January 30, 2015 09:27
* Added ui-scroll
* Added infinite scroller
* Added loader
@Mironor
Copy link

Mironor commented Feb 11, 2015

Looks like a fix for #221

@rahulmranjith
Copy link

The ui-scroll is still not available right ? I don't see the changes in the latest build. Will this be fixed anytime soon ? I cannot migrate from ui-select2 because of this .:(

@PavelKonon
Copy link

+1

@scharfmedia
Copy link

+1, i see this PR is a month old without feedback, any ETA for this?

@domakas
Copy link
Author

domakas commented Mar 3, 2015

I will try to add a example page for this when I have time, maybe it will be merged faster then.

@amcdnl
Copy link
Contributor

amcdnl commented Mar 6, 2015

Whats the premise behind adding ui-scroll vs just native?

@rahulmranjith
Copy link

@domakas DId u get time to look into this ? I am not able to migrate because of this . Please .

@dimirc
Copy link
Contributor

dimirc commented Mar 11, 2015

Is this adding a dependency to other library? we should avoid external dependency and maybe work on compatibility

@amcdnl
Copy link
Contributor

amcdnl commented Mar 11, 2015

I second that

@asm0dey
Copy link

asm0dey commented Mar 12, 2015

If we should avoid dependency - maybe it's option to add this as separate bower module, that integrates with ui-scroll on one side and with ui-select on another?

@domakas
Copy link
Author

domakas commented Mar 12, 2015

Still haven't time to make the demo page, but I hope to make it soon.

Regarding dependencies, I implemented ui-scroll just because of #316 suggestion. Either way, it's optional, you don't have to add ui-scroll to your project if you are not using this scrolling feature.

@amcdnl ui-scroll adds support for "virtual scrolling", that is you can have 10k items in the list, and it would still perform normal.

@nlevari
Copy link

nlevari commented Mar 24, 2015

I wish I had a demo or a readme file instead of Digging the code for answers. Any ETA?

@amcdnl
Copy link
Contributor

amcdnl commented Mar 24, 2015

@domakas I see and totally see the value there....but I don't think thats the typical scenario and users of that would typically does a AJAX search instead.

@dimirc thoughts?

@RyanVoronyak
Copy link

Will this be merged into the master soon? ETA?

@jonathanchris
Copy link

@domakas Thanks for the work on this, but I need some assistance with an example or at least just how this would look to get it working. Specifically with the infinite attribute, I can't seem to put anything in there that works. So far i've pulled down your branch, built it, and put it in my source. Then tried to add it to an existing working ui-select example but i'm not getting any results.

@PowerKiKi
Copy link

@scharfmedia, @nlevari, @rvoronyak without any tests nor documentation, the chances to get it merged seem pretty slim

@hummorsa
Copy link

Hi, is this going to be included in the ui-select at all ? or is something that was cancelled ?

@amcdnl
Copy link
Contributor

amcdnl commented Apr 29, 2015

@hummorsa No, I do not believe so. It doesn't fit in with the vision of ui-select. I'd advise @domakas to make a public repo that includes this and I'll cite it in the docs.

@amcdnl amcdnl closed this Apr 29, 2015
@mlibanori
Copy link

how use ui-select + ui-scroll ?? is there some example ??

@filipe3sousa
Copy link

@domakas how can we use this?

@domakas
Copy link
Author

domakas commented Feb 5, 2016

Sorry for delayed response for all of you. After some time working with this, it's still buggy and probably shouldn't be used yet. This requires big time effort to make it work properly, which I don't have at the moment. I will try to dig down a demo page, so someone maybe could continue working on this.

Sorry for all the fuss.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet